JS Login Help!!

[Blake]

This seems the right place to ask :P

I'm making a JS login using an array, which locks the user out after 3 tries. It's for an assignment, and I wouldn't usually ask but for the life of me, I can't figure out why it still says "x incorrect login attempts" even when I get it right.

var username = new Array();
username[0] = "Blake";
username[1] = "Morgan";
username[2] = "Steve";
username[3] = "Admin";
username[4] = "Adam";

var password = new Array();
password[0] = "pass1";
password[1] = "pass2";
password[2] = "pass3";
password[3] = "pass4";
password[4] = "pass5";

var logincheck = false;
var Number = 1;

function Login()

   {

	for (var i = 0; i < username.length; i = i + 1)
		{
		if ((username[i] == document.LForm.UName.value) && (password[i] == document.LForm.PWord.value))
			{
			window.location.href="members.htm";
			logincheck = true;
			}	
	    	}
		 
	{
		if (!logincheck)
		{ 	
		alert("Incorrect Username or Password combination.");
		} 
	{
  	do {
   	    alert(Number + " " + "incorrect login attempts.");
    	    Number++;
  		}
		while(Number < 1)
  		}
	}
	if (Number > 3)
		{
		document.location.href = 'blocked.htm'
		}
    }

TIA, i'm going insane over this.. lol!

[FuRbY*]

not that im familiar with JS, but whats the benefit in using an array over an if statement?

[Blake]

The benefit is my assignment indicates I need to use an array

Else i'd have finished ages ago :P

[chemicalNova]

You have a few stray brackets all over the place..

var username = new Array();
username[0] = "Blake";
username[1] = "Morgan";
username[2] = "Steve";
username[3] = "Admin";
username[4] = "Adam";

var password = new Array();
password[0] = "pass1";
password[1] = "pass2";
password[2] = "pass3";
password[3] = "pass4";
password[4] = "pass5";

var logincheck = false;
var Number = 1;

function Login()

   {

	for (var i = 0; i < username.length; i = i + 1)
		{
		if ((username[i] == document.LForm.UName.value) && (password[i] == document.LForm.PWord.value))
			{
			window.location.href="members.htm";
			logincheck = true;
			}	
	    	}
		 
	{ <---- that one
		if (!logincheck)
		{ 	
		alert("Incorrect Username or Password combination.");
		} 
	{ <--- that one
  	do {
   	    alert(Number + " " + "incorrect login attempts.");
    	    Number++;
  		}
		while(Number < 1)
  		} <------
	} <---- this one and the above one
	if (Number > 3)
		{
		document.location.href = 'blocked.htm'
		}
    }

It throws your code completely out of whack. Try removing the ones I suggested.. You're also missing a semicolon after the while.

What browser are you using? I'm fairly certain IE would throw errors with that script.

chem

[Blake]

Using both IE and Firefox, as I have to comply to w3c standards.

And yeah, i'm a fairly messy coder, lol.

[chemicalNova]

Did that fix it? Having the brackets there stuff up the parsing completely.

(btw, i=i+1 looks so yuck.. try ++i or i++ )

chem

[Blake]

Same thing though! And nah, neither change anything

[chemicalNova]

Can't read **** on these forums so I re-wrote it. On the third attempt it goes to blocked ..

var username = new Array();
username[0] = "Blake";
username[1] = "Morgan";
username[2] = "Steve";
username[3] = "Admin";
username[4] = "Adam";

var password = new Array();
password[0] = "pass1";
password[1] = "pass2";
password[2] = "pass3";
password[3] = "pass4";
password[4] = "pass5";

var wrong_attempts = 0;
var success = false;

function Login()
{
    for (var i = 0; i < username.length; ++i)
    {
        if (wrong_attempts > 1)
            window.location.href = "blocked.htm";

        if ((username[i] == document.LForm.UName.value) && (password[i] == document.LForm.PWord.value)) {
            success = true;
            window.location.href = "members.htm";
            break;        
        }
    }

    if (!success) {
        alert('Incorrect Username or Password combination');
        wrong_attempts++;
    }
}

chem

[chemicalNova]

I fixed the above post.. I ****ed the loop. Should work now.

chem

[Blake]

Thanks heaps

[Khaless]

Originally Posted by Blake

Using both IE and Firefox, as I have to comply to w3c standards.

And yeah, i'm a fairly messy coder, lol.

You realise conforming to w3c standards does not make your code work in both browsers.

Case in point, if we want to set an event callback, setAttribute() the standard versus
attachEvent() or obj.property = function() { ... } for ie.

[Khaless]

Remember JS authentication is broken by definition ('client side'). And also, if you ever feel like making things neater, look at how we can form objects on the fly in js. For Example

var details = [ {username: 'jim', password: 'jimmy'}, {username: 'bob', password: 'bobby'} ]

Will give us basically an array of username/password tuples (objects)
so we could
details[0].password // jim's password

which means you could:

for (var i in details) {
if(details[i].username == ...
}

gl, hf!